Skip to content

fix(manual): use render instead for the colormixin example - #1465

Merged
hmenke merged 1 commit into
pgf-tikz:masterfrom
hmenke:manual
Sep 4, 2026
Merged

fix(manual): use render instead for the colormixin example#1465
hmenke merged 1 commit into
pgf-tikz:masterfrom
hmenke:manual

Conversation

@hmenke

@hmenke hmenke commented Jul 31, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Motivation for this change

Fixes #1134

image

Checklist

Please signoff your commits to explicitly state your agreement to the Developer Certificate of Origin. If that is not possible you may check the boxes below instead:

@hmenke
hmenke requested a review from Mo-Gul July 31, 2026 12:33
@hmenke
hmenke force-pushed the manual branch 2 times, most recently from 416c321 to 1120110 Compare July 31, 2026 15:14
@hmenke

This comment was marked as outdated.

Sign in to view
@Mo-Gul

Mo-Gul commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

so just to be sure: For the moment nothing to do for me, right!?

@hmenke

hmenke commented Aug 4, 2026

Copy link
Copy Markdown
Member Author

@Mo-Gul Nothing to do at the moment. I'll also mark this as draft.

@hmenke
hmenke marked this pull request as draft August 4, 2026 04:32
@hmenke hmenke added this to the 3.1.13 milestone Aug 13, 2026
@hmenke
fix(manual): use render instead for the colormixin example
f4463f9 
Signed-off-by: Henri Menke <henri@henrimenke.de>
@hmenke
hmenke marked this pull request as ready for review August 18, 2026 05:59
@hmenke

hmenke commented Aug 18, 2026

Copy link
Copy Markdown
Member Author

Converting ^^M to space globally breaks too much stuff. I've now opted to only do it for the xxcolor example.

@hmenke
hmenke requested a review from muzimuzhi August 19, 2026 10:06
@muzimuzhi

muzimuzhi commented Aug 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Member
image

Double spaces are still found. It seems the leading spaces on source line 46 account.

pgf/doc/generic/pgf/pgfmanual-en-xxcolor.tex

Lines 44 to 46 in 0a859c8

\color{green} dark washed-out green text,%
\end{colormixin}
back to washed-out blue text,%

BTW changes to pgfmanual-test.tex need not be committed. You can run git update-index --skip-worktree doc/generic/pgf/pgfmanual-test.tex to ignore changes to this tracked file (ref). (Problematic when switching branches.)

@hmenke hmenke changed the title fix(manual): convert ^^M to space instead of ignored fix(manual): use render instead for the colormixin example Sep 3, 2026
@hmenke

hmenke commented Sep 3, 2026

Copy link
Copy Markdown
Member Author

I gave up trying to fix the spaces. Now using render instead which seems to work fine.

@muzimuzhi

muzimuzhi commented Sep 3, 2026

Copy link
Copy Markdown
Member

Nice trick! I didn't know the render instead option of codeexample env before.

Maybe it's time to generate a brief doc for the pgfmanual package, with the aid of AI.

@hmenke
hmenke merged commit 1a41623 into pgf-tikz:master Sep 4, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@muzimuzhi muzimuzhi muzimuzhi approved these changes
@Mo-Gul Mo-Gul Awaiting requested review from Mo-Gul

Assignees

No one assigned

Labels

None yet

Milestone

3.1.13

Development

Successfully merging this pull request may close these issues.

Improve codeexample for xxcolor

3 participants

@hmenke @Mo-Gul @muzimuzhi